Skip to content

Improve Clean and Build tasks #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 16, 2020
Merged

Improve Clean and Build tasks #1144

merged 13 commits into from
Jan 16, 2020

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Jan 6, 2020 •
edited
Loading

  • Change Build to remove bin directories that must always be refreshed in the output binary
  • Change Clean to also wash away the downloaded bundled modules

Also fixes #1135.

@rjmholt rjmholt requested a review from TylerLeonhardt January 6, 2020 22:09
@TylerLeonhardt
Copy link
Member

ERROR: The term 'Test-Item' is not recognized as the name of a cmdlet, function, script file, or operable program.

did you mean Test-Path?

TylerLeonhardt
TylerLeonhardt approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjmholt rjmholt merged commit f16d657 into PowerShell:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix PSES version in BuildInfo
2 participants
@rjmholt @TylerLeonhardt